Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5101 - go back to docker/build-push-action@v4 #2796

Merged
merged 2 commits into from
Sep 11, 2023
Merged

BC-5101 - go back to docker/build-push-action@v4 #2796

merged 2 commits into from
Sep 11, 2023

Conversation

mamutmk5
Copy link
Member

@mamutmk5 mamutmk5 commented Sep 11, 2023 •
edited
Loading

Short Description

Go back to docker/build-push-action@v4 and solfe the issue with the malformed docker config

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/BC-5101
hpi-schul-cloud/schulcloud-server#4397
hpi-schul-cloud/schulcloud-client#3300
hpi-schul-cloud/superhero-dashboard#230
hpi-schul-cloud/schulcloud-calendar#142
hpi-schul-cloud/antivirus_check_service#42
hpi-schul-cloud/version-aggregator#11
hpi-schul-cloud/h5p-staticfiles-server#4

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@mamutmk5 mamutmk5 self-assigned this Sep 11, 2023
This was referenced Sep 11, 2023
Merged
Merged
This was referenced Sep 11, 2023
Merged
Merged
Merged
Merged
Merged
@mamutmk5 mamutmk5 enabled auto-merge (squash) September 11, 2023 08:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@mamutmk5 mamutmk5 merged commit 2fccb56 into main Sep 11, 2023
@mamutmk5 mamutmk5 deleted the BC-5101 branch September 11, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loki-Afro Loki-Afro Loki-Afro approved these changes

@bn-pass bn-pass Awaiting requested review from bn-pass

Assignees

@mamutmk5 mamutmk5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamutmk5 @Loki-Afro